Skip to content

Commit

Permalink
[gbmusic] fix #3737; fix autostart saved state; pass playpause to gb …
Browse files Browse the repository at this point in the history
…instead of play; allow widget clicks
  • Loading branch information
thinkpoop committed Feb 8, 2025
1 parent c517854 commit 205e953
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 8 deletions.
1 change: 1 addition & 0 deletions apps/gbmusic/ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@
0.11: Use default Bangle formatter for booleans
0.12: Issue newline before GB commands (solves issue with console.log and ignored commands)
0.13: Upgrade to new translation system
0.14: Fix auto-start saved state; fix clearing track number; allow widget clicks
16 changes: 11 additions & 5 deletions apps/gbmusic/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ function rScroller(l) {
const w = g.stringWidth(l.label)+40,
y = l.y+l.h/2;
l.offset = l.offset%w;
g.setClipRect(l.x, l.y, l.x+l.w-1, l.y+l.h-1)
.setColor(l.col).setBgColor(l.bgCol) // need to set colors: iScroll calls this function outside Layout
//g.setClipRect(l.x, l.y, l.x+l.w-1, l.y+l.h-1)
g.setColor(l.col).setBgColor(l.bgCol) // need to set colors: iScroll calls this function outside Layout
.setFontAlign(-1, 0) // left center
.clearRect(l.x, l.y, l.x+l.w-1, l.y+l.h-1)
.drawString(l.label, l.x-l.offset+40, y)
Expand Down Expand Up @@ -433,15 +433,21 @@ function sendCommand(command) {
drawControls();
}

function handleTouch(btn, pos) {
if (pos === undefined || pos.y >= Bangle.appRect.y) {
togglePlay();
}
}

function togglePlay() {
sendCommand(stat==="play" ? "pause" : "play");
sendCommand(stat==="play" ? "pause" : "playpause");
}

/**
* Setup touch+swipe for Bangle.js 1
*/
function touch1() {
Bangle.on("touch", togglePlay);
Bangle.on("touch", handleTouch);
Bangle.on("swipe", dir => {
sendCommand(dir===1 ? "previous" : "next");
});
Expand All @@ -450,7 +456,7 @@ function touch1() {
* Setup touch+swipe for Bangle.js 2
*/
function touch2() {
Bangle.on("touch", togglePlay);
Bangle.on("touch", handleTouch);
// swiping
let drag;
Bangle.on("drag", e => {
Expand Down
4 changes: 2 additions & 2 deletions apps/gbmusic/boot.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ setTimeout( // make other boot code run first, so we override e.g. android.boot.
* Only runs while other apps are loaded
*/
function check() {
if (s!=="play" || !i || !a || !Bangle.CLOCK) return; // only launch app if we know which song we are playing, and autoLoad is enabled
if ((!s || s.state!=="play") || !i || !a || !Bangle.CLOCK) return; // only launch app if we know which song we are playing, and autoLoad is enabled
delete (i.t);
// store info and launch music app
require("Storage").writeJSON("gbmusic.load.json", {
Expand All @@ -27,7 +27,7 @@ setTimeout( // make other boot code run first, so we override e.g. android.boot.
i = e;
return APP ? info(e) : check();
case "musicstate":
s = e.state;
s = e;
return APP ? state(e) : check();
default:
// pass on other events
Expand Down
2 changes: 1 addition & 1 deletion apps/gbmusic/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"id": "gbmusic",
"name": "Gadgetbridge Music Controls",
"shortName": "Music Controls",
"version": "0.13",
"version": "0.14",
"description": "Control the music on your Gadgetbridge-connected phone",
"icon": "icon.png",
"screenshots": [{"url":"screenshot_v1_d.png"},{"url":"screenshot_v1_l.png"},
Expand Down

0 comments on commit 205e953

Please sign in to comment.