msgtwscr: Temporarily activate scroll on twist function when a new message triggers the message app.#3714
Closed
thyttan wants to merge 135 commits intoespruino:masterfrom
Closed
msgtwscr: Temporarily activate scroll on twist function when a new message triggers the message app.#3714thyttan wants to merge 135 commits intoespruino:masterfrom
thyttan wants to merge 135 commits intoespruino:masterfrom
Conversation
Temporarily activate scroll on twist function when a new message triggers the message app.
thyttan
force-pushed
the
msgtwistscroll
branch
from
c32e33d to
d715095
Compare
we also disable jumping jacks detector
sets width to 0 and checks inside the draw function rather than leaving them undefined
Fixes a bug in the dot coloring and adds more screenshots
I didn't realize it would choke on further dots in the versioning.
…e to gb instead of play; allow widget clicks
Discovered that, in the events synchronized from Gadgetbridge, all-day events have timestamps that disregard local timezones. Specifically, all-day events always start at midnight UTC, which caused calendar to display them starting at a different time depending on time zone offset (e.g. for my offset of -5, I see all-day events start at 19:00 the day before). Borrowed logic from the agenda app to correct this. This logic shifts an all-day event's start time to start at midnight in the current time zone. Also specify all-day events as type "o" (other) so the full day is highlighted and the start time is not displayed. Note that this does nothing to handle all-day events that span more than one day (only the first day is highlighted in the calendar). Also note that I'm not sure how this will handle time zone changes, like shifting to/from daylight savings time.
Commented out the utility functions and variables used to make documentation. Seems like there should be a better approach, maybe an extra dev.js?
Maybe implement this in a separate app instead.
Collaborator
Author
|
Closing based on #3685 (comment) since this was sort of a companion to that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be installed from my app loader: https://thyttan.github.io/BangleApps/?id=msgtwscr