-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grandfather Clock Widget #3724
Grandfather Clock Widget #3724
Conversation
once settings are implemented, this will be disabled by default
Works for me! I'd prefer though if the app id was just "grandfatherclock" since most app ids only use letters.
Gordon pays icons8.com for a license to use the icons they provide - maybe you can find one you like there? https://www.espruino.com/Bangle.js+First+App#icon-timer-img
👍 |
I'm happy with how this works now.
I'd like someone to take a look at the WIDGETS entry in the widget.js file, I'm not sure if my implementation of the show/hide is safe (no errors, but I haven't looked into how those values are handled). |
So what you do is set the widget draw method to I guess if you tested it and it works we're good - what do you think @bobrippling ? What many other widgets seem to do is change the width to zero and then redraw. But that is maybe only needed if it's not statically either shown or not. |
Yeah looks good to me - I think perhaps we change to a zero width + check in the widget draw method to match the others, so if some future code assumes |
That makes sense to me. I'll drop that change in now. |
Or just change |
sets width to 0 and checks inside the draw function rather than leaving them undefined
Just say when you tested it again and I will merge 🙏 |
Updated the app and it all works now. Turns out I was wrong and there were errors when leaving the draw function undefined. I assume the code that handles it always tries to run a draw() if there's an entry in WIDGETS - makes sense. |
Thank you 🎆 |
( Available at: https://yogsoy.github.io/BangleApps/?id=grandfather-clock )
A widget that uses vibrations to count fractions of the hour and the hour of the day, much like an old grandfather clock.
I did try to work on this as a set of options for Chimer, but found that it was easier and more efficient to make a separate widget. Keeps both apps lighter for people that need them - there's quite a bit of logic that went into the counting function.
Goals:
Current considerations: