Skip to content

Commit

Permalink
Remove unnecessary make command to install tools in e2e tests
Browse files Browse the repository at this point in the history
The make kustomize and controller-gen targets are prerequisites of the
targets later called in the e2e tests, so there's no need to manually
trigger them.

Signed-off-by: Ivan Valdes <[email protected]>
  • Loading branch information
ivanvc committed Feb 15, 2025
1 parent f03e687 commit 3192fb9
Showing 1 changed file with 1 addition and 13 deletions.
14 changes: 1 addition & 13 deletions test/e2e/e2e_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,9 @@ func TestMain(m *testing.M) {

// prepare the resources
func(ctx context.Context, cfg *envconf.Config) (context.Context, error) {
log.Println("Installing bin tools...")
cmd := exec.Command("make", "kustomize")
if _, err := test_utils.Run(cmd); err != nil {
log.Printf("Failed to install kustomize binary: %s", err)
return ctx, err
}
cmd = exec.Command("make", "controller-gen")
if _, err := test_utils.Run(cmd); err != nil {
log.Printf("Failed to install controller-gen binary: %s", err)
return ctx, err
}

// gen manifest files
log.Println("Generate manifests...")
cmd = exec.Command("make", "manifests")
cmd := exec.Command("make", "manifests")
if _, err := test_utils.Run(cmd); err != nil {
log.Printf("Failed to generate manifests: %s", err)
return ctx, err
Expand Down

0 comments on commit 3192fb9

Please sign in to comment.