Initial implementation for the Reconcile Logic #17
Conversation
|
@gdasson Thanks for the PR. Could you please resolve the comments and ensure the PR is in the best shape you think before marking it as ready for review and also remove "draft" from the title? I will take a second round of review once you mark it as ready for review. |
gdasson
changed the title
|
@hakman @justinsb @jmhbnz @ArkaSaha30 Please take a look at this PR. It will be the base for the following PRs. Thanks. cc @ivanvc Also I am most concerned about the e2e test as mentioned in #17 (comment) |
|
@gdasson please rebase this PR, thx |
|
@gdasson please rebase this PR and let's merge this PR. Also squash the commits (I can also do it for you if you have any difficulties). I will create more following tasks. |
|
@ahrtr : I'll work on it today. I had a busy couple of days, I apologize for not responding earlier. |
gdasson
force-pushed
the
feature/initial_draft2
branch
from
3511661 to
6c46e88
Compare
Signed-off-by: Gaurav Dasson <[email protected]>
gdasson
force-pushed
the
feature/initial_draft2
branch
from
6c46e88 to
2906c2c
Compare
|
@ahrtr : Done. Please review. Thanks. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, gdasson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is an intial implementation of the design mentioned here
The code is now in working state and able to create an etcd cluster. However, the code will continue to be refined and made more production ready as we review and incorporate feedback.