Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some HealthInterval to reduce the time to run DowngradeUpgradeMembers #19317

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

siyuanfoundation
Copy link
Contributor

@siyuanfoundation siyuanfoundation commented Feb 2, 2025

Part of #19306.

This would reduce the time to run DowngradeUpgradeMembers. But it still would not complete in 1min (still needs about 90s with this change for downgrading and upgrading all 3 members).

@gangli113 is working on changing the failpoint timeout for the MemberDowngradeUpgrade failpoint.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (b197332) to head (6b0a9cd).
Report is 4 commits behind head on main.

Additional details and impacted files

see 18 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19317   +/-   ##
=======================================
  Coverage   68.83%   68.83%           
=======================================
  Files         420      420           
  Lines       35701    35701           
=======================================
  Hits        24574    24574           
- Misses       9701     9706    +5     
+ Partials     1426     1421    -5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b197332...6b0a9cd. Read the comment docs.

@siyuanfoundation siyuanfoundation marked this pull request as ready for review February 3, 2025 04:24
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 2bddcd4 into etcd-io:main Feb 3, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants