-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove passing of anonymous visualize function #19370
Conversation
Hi @shashwat010. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Please fix DCO |
Please squash commits. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 22 files with indirect coverage changes @@ Coverage Diff @@
## main #19370 +/- ##
==========================================
- Coverage 68.94% 68.83% -0.12%
==========================================
Files 420 420
Lines 35759 35764 +5
==========================================
- Hits 24654 24618 -36
- Misses 9684 9714 +30
- Partials 1421 1432 +11 Continue to review full report in Codecov by Sentry.
|
e65a92b
to
8e65b83
Compare
8e65b83
to
976cc31
Compare
a92d284
to
4075390
Compare
9d2a7b3
to
a40ebd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one suggestion. It looks good. Thanks
Signed-off-by: shashwat-jain <[email protected]>
a40ebd2
to
1709422
Compare
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius, shashwat010 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #19089
Changes made:
Refactored operations.go
Refactored the validateLinearizableOperationsAndVisualize function
Eliminated the anonymous function for visualization.
Introduced a Results struct to store LinearizationInfo, Model, and the logger.
The Results struct simplifies the code by removing the need to pass these components separately.