Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove passing of anonymous visualize function #19370

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

shashwat010
Copy link
Contributor

Closes #19089

Changes made:
Refactored operations.go

Refactored the validateLinearizableOperationsAndVisualize function
Eliminated the anonymous function for visualization.
Introduced a Results struct to store LinearizationInfo, Model, and the logger.
The Results struct simplifies the code by removing the need to pass these components separately.

@k8s-ci-robot
Copy link

Hi @shashwat010. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serathius
Copy link
Member

/ok-to-test

@serathius
Copy link
Member

Please fix DCO

@serathius
Copy link
Member

Please squash commits.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (fefce54) to head (5414dba).
Report is 3 commits behind head on main.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19370      +/-   ##
==========================================
- Coverage   68.94%   68.83%   -0.12%     
==========================================
  Files         420      420              
  Lines       35759    35764       +5     
==========================================
- Hits        24654    24618      -36     
- Misses       9684     9714      +30     
- Partials     1421     1432      +11     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fefce54...5414dba. Read the comment docs.

@shashwat010 shashwat010 force-pushed the visualize branch 2 times, most recently from e65a92b to 8e65b83 Compare February 11, 2025 05:50
@shashwat010 shashwat010 force-pushed the visualize branch 2 times, most recently from a92d284 to 4075390 Compare February 11, 2025 05:57
@shashwat010 shashwat010 force-pushed the visualize branch 3 times, most recently from 9d2a7b3 to a40ebd2 Compare February 11, 2025 07:24
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion. It looks good. Thanks

tests/robustness/validate/operations.go Outdated Show resolved Hide resolved
@shashwat010
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, shashwat010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit c0e7e8c into etcd-io:main Feb 12, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Remove passing of anonymous visualize function
4 participants