Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce TestDowngradeCancellationAfterDowngrading2InClusterOf3 failure consistently #19396

Closed
wants to merge 2 commits into from
Closed

Reproduce TestDowngradeCancellationAfterDowngrading2InClusterOf3 failure consistently #19396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdc8603
Reproduce TestDowngradeCancellationAfterDowngrading2InClusterOf3 fail…
Feb 12, 2025
0951f70
Add more logging
Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions server/etcdserver/version/monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,12 @@ func (m *Monitor) UpdateStorageVersionIfNeeded() {
zap.String("target-version", d.TargetVersion),
zap.String("server-version", version.Version),
)
} else if d != nil && !d.Enabled {
m.lg.Info(
"The server is in downgrade cancellation state",
zap.String("target-version", d.TargetVersion),
zap.String("server-version", version.Version),
)
}
}
}
Expand Down
3 changes: 3 additions & 0 deletions tests/framework/e2e/downgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ func DowngradeUpgradeMembersByID(t *testing.T, lg *zap.Logger, clus *EtcdProcess
return err
}
}

time.Sleep(5 * time.Second)

lg.Info("Validating versions")
for _, memberID := range membersToChange {
member := clus.Procs[memberID]
Expand Down