Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.6] Move interface AlarmBackend from server/etcdserver/api/v3alarm to server/storage/schema to fix the unexported-return lint error #19455

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #19342

/assign ivanvc

@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Feb 20, 2025

/ok-to-test

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (fd47d1b) to head (1fd8887).
Report is 2 commits behind head on release-3.6.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/api/v3alarm/alarms.go 84.21% <100.00%> (ø)
server/storage/schema/alarm.go 86.66% <100.00%> (ø)

... and 20 files with indirect coverage changes

@@             Coverage Diff              @@
##           release-3.6   #19455   +/-   ##
============================================
  Coverage        68.91%   68.91%           
============================================
  Files              420      420           
  Lines            35753    35753           
============================================
+ Hits             24638    24640    +2     
- Misses            9687     9689    +2     
+ Partials          1428     1424    -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd47d1b...1fd8887. Read the comment docs.

@ivanvc
Copy link
Member

ivanvc commented Feb 21, 2025

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM. Defer the decision if we want it in v3.6.0 to @ahrt. However, as I mentioned if we don't do it, we'll need to deprecate in main.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 0f89474 into etcd-io:release-3.6 Feb 21, 2025
39 checks passed
@ivanvc ivanvc mentioned this pull request Feb 24, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants