Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.6] etcdserver: Update description for count field in the RangeResponse message #19468

Open
wants to merge 1 commit into
base: release-3.6
Choose a base branch
from

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #19446

/assign ahrtr

…essage

To highlight that it doesn't honour the limit and filters (Min or Max, Create or Modify, Revisions)

Signed-off-by: Ashik J M <[email protected]>
@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Feb 23, 2025

/ok-to-test

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.97%. Comparing base (0f89474) to head (ec0aa63).

Additional details and impacted files

see 18 files with indirect coverage changes

@@               Coverage Diff               @@
##           release-3.6   #19468      +/-   ##
===============================================
- Coverage        68.99%   68.97%   -0.03%     
===============================================
  Files              420      420              
  Lines            35753    35753              
===============================================
- Hits             24669    24659      -10     
- Misses            9662     9676      +14     
+ Partials          1422     1418       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f89474...ec0aa63. Read the comment docs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member

ahrtr commented Feb 23, 2025

cc @fuweid @ivanvc @jmhbnz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants