Add e2e test

[ahrtr]

Currently there is only unit test. It would be great if we have an e2e test suite, and it's supposed to be triggered on each PR or commits on master.

[Elbehery]

@ahrtr is there a doc explains what is needed here ?

[ahrtr]

@ahrtr is there a doc explains what is needed here ?

There is no doc on this. The ideal is straightforward. We need to start the HTTP server, and tests all RESTful APIs.

gofail/runtime/http.go

Line 39 in 806f13e

func (*httpHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {

[Elbehery]

ok i can take this 👍🏽

please assign me

[bhuber]

Is this still relevant? I see there are now integration tests defined in /integration/** being run with each PR/merge, e.g. https://github.com/etcd-io/gofail/actions/runs/12990996684/job/36227475614 . Is the goal of this task to simply add one there that exercises the http REST endpoints?

[Elbehery]

thanks @bhuber

iiuc, this should test all REST endpoints, yes

[bhuber]

Thanks for the quick response @Elbehery . Mind if I take a crack at it?

[Elbehery]

yes please 👍🏽

[Elbehery]

just assigned u 👍🏽

[bhuber]

@Elbehery I submitted a PR, but it looks like nobody's been assigned to review it. https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#the-code-review-process suggests reviewers should be assigned automatically, so not sure what's happened here. Any tips on how to proceed?