Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integ test for http server #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bhuber
Copy link

@bhuber bhuber commented Feb 13, 2025

Overview

This fixes #40 , hopefully satisfactorily. The intent here is to make a generic and flexible test harness for exercising the gofail http api. I've added some obvious basic tests; I'm sure the maintainers can think of more to add in the future. I also fixed several inaccuracies in the documentation, and added a few missing pieces I found during the course of implementation.

The code should be pretty self explanatory. The main explanation of the test setup is in the godoc for TestAll in integration/server/server_test.go .

This is my first PR to this repo, and I did my best to follow all the contribution instructions I could find, but please let me know if I missed anything.

Testing

This fixes etcd-io#40

Signed-off-by: Bennet Huber <[email protected]>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bhuber
Once this PR has been reviewed and has the lgtm label, please assign ptabor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member

ahrtr commented Feb 14, 2025

cc @henrybear327, @ivanvc and @ArkaSaha30 for comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Add e2e test
3 participants