Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes #40 , hopefully satisfactorily. The intent here is to make a generic and flexible test harness for exercising the gofail http api. I've added some obvious basic tests; I'm sure the maintainers can think of more to add in the future. I also fixed several inaccuracies in the documentation, and added a few missing pieces I found during the course of implementation.
The code should be pretty self explanatory. The main explanation of the test setup is in the godoc for
TestAll
in integration/server/server_test.go .This is my first PR to this repo, and I did my best to follow all the contribution instructions I could find, but please let me know if I missed anything.
Testing
make run-all-integration-tests
works locally