Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go 1.24.0 #268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Elbehery
Copy link
Member

Signed-off-by: Mustafa Elbehery <[email protected]>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Elbehery
Copy link
Member Author

the failing test is not caused by this PR

Running [/home/runner/golangci-lint-1.60.1-linux-amd64/golangci-lint run] in [/home/runner/work/raft/raft] ...
  Error: logger.go:88:5: l.Output undefined (type *DefaultLogger has no field or method Output) (typecheck)
  		l.Output(calldepth, header("DEBUG", fmt.Sprint(v...)))

@Elbehery Elbehery mentioned this pull request Feb 16, 2025
@ivanvc
Copy link
Member

ivanvc commented Feb 18, 2025

/retest

@ivanvc
Copy link
Member

ivanvc commented Feb 18, 2025

the failing test is not caused by this PR

It looks like the linter is complaining about the functions from the embedded structs (composition).

@Elbehery
Copy link
Member Author

so bumping the linter version will fix the issue

@Elbehery
Copy link
Member Author

oh its already here #270

but the linter is failing as well 😆

@ivanvc
Copy link
Member

ivanvc commented Feb 18, 2025

So, typecheck is not a linter. I was checking the golangci-lint repository and found this: https://golangci-lint.run/welcome/faq/#why-do-you-have-typecheck-errors

@ivanvc
Copy link
Member

ivanvc commented Feb 20, 2025

I tested locally with golangci-lint v1.64.5, and it doesn't return any errors. If I run it with 1.63.4 it does.

@Elbehery, I believe you need to update to the latest golangci-lint version across the repositories, not to 1.63.4.

Note that you will also need to rebase your pull requests to pick up the latest version.

Refer to my commit on top of your branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants