-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go 1.24.0 #268
base: main
Are you sure you want to change the base?
Bump go 1.24.0 #268
Conversation
Signed-off-by: Mustafa Elbehery <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Elbehery The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the failing test is not caused by this PR
|
/retest |
It looks like the linter is complaining about the functions from the embedded structs (composition). |
so bumping the linter version will fix the issue |
oh its already here #270 but the linter is failing as well 😆 |
So, |
I tested locally with golangci-lint v1.64.5, and it doesn't return any errors. If I run it with 1.63.4 it does. @Elbehery, I believe you need to update to the latest golangci-lint version across the repositories, not to 1.63.4. Note that you will also need to rebase your pull requests to pick up the latest version. Refer to my commit on top of your branch: |
ref etcd-io/etcd#19417