fix(devshell): isolate uv from Nix Python packages - #40
Merged
Conversation
Nix's Python setup hooks populate PYTHONPATH with propagated packages that take precedence over the project environment. Unset the inherited path on shell entry so uv resolves dependencies from .venv.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39.
Summary
Before this change, Nix development shells exposed Python packages propagated by Nix’s
pre-commitpackage throughPYTHONPATH. Those entries took precedence over uv’s project environment, souv run pytestcould launch pytest from.venvwhile importing_pytestfrom the Nix store.The shared development-shell
shellHooknow unsets the inheritedPYTHONPATHbefore installing Git hooks. Project commands therefore resolve dependencies from.venv, while Nix’s wrappedpre-commitexecutable continues to install and run normally.This fixes the environment mismatch exposed by #38 without changing CI commands or project dependencies.
Test plan
py310throughpy314, verifyPYTHONPATHis unset, pytest imports from the matching.venv, no Nix-storesite-packagesentries appear insys.path, and all 78 tests pass.pre-commit validate-config .pre-commit-config.yamlandpre-commit run --all-files --show-diff-on-failure.nix flake check --no-build.Checklist
uv run pytest)pre-commit run --all-filesexits successfullynix flake check --no-buildexits successfully