fix(client): encode and scope HTTP Basic credentials - #42
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41
Summary
Configuring
Clientwith a username and password raisedAttributeErrorbefore it could make a request because it called a removed Base64 function.This pull request:
Authorizationheader on both POST and forced-GET requests.Request.add_unredirected_header(), sourllibdoes not copy credentials to automatically redirected requests.Test plan
uv run pytest src/oaipmh/tests/test_client.py -k "http_basic_authentication or request_without_credentials_omits_authorization"exercises authenticated POST, forced GET, text credential encoding, redirect confinement, and unauthenticated requests.uv run pytestruns the complete test suite; all 83 tests pass locally.Checklist
uv run pytest)