Correctly check memory alignment based on size of operand #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The RISC-V specifications indicate the following in section "14.2. "Zalrsc" Extension for Load-Reserved/Store-Conditional Instructions".
However, the current implementation only checks that the address is aligned on 4 bytes. This check is not accurate for LR.D and SC.D instructions which use 8-byte size.
This PR ensures that
mod(addr, size) == 0
instead of the current logical and check.