Skip to content

Added BiLira (TRYB) #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ahmet
Copy link

@ahmet ahmet commented May 12, 2025

Description

Added BiLira (TRYB), which is a stablecoin, pegged against the Turkish Lira (TRY) and fully backed with TRY (Turkish Lira) 100%.

@ahmet ahmet requested review from wbnns and a team as code owners May 12, 2025 11:53
Copy link

wiz-inc-a178a98b5d bot commented May 12, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities
Data Finding Sensitive Data 1 Low
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total 1 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@wbnns wbnns added the base PR require review from base team label May 14, 2025
@wbnns wbnns closed this May 28, 2025
@wbnns wbnns reopened this May 28, 2025
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmet

Hi there! CI is failing on this PR, could you please resolve?

@fainashalts
Copy link
Collaborator

Hi @ahmet if you rebase against the latest master it will probably fix the CI issue here!

@ahmet
Copy link
Author

ahmet commented May 28, 2025

Will check, thanks 👍

@ahmet
Copy link
Author

ahmet commented May 28, 2025

I've synced our fork using "sync fork" button on Github UI which merged upstream instead of rebasing and confused by CircleCI check's "couldnt find usable config.yml ..." even though the fork has config.yml, does merge cause it or something else, any suggestions?

@fainashalts
Copy link
Collaborator

I've synced our fork using "sync fork" button on Github UI which merged upstream instead of rebasing and confused by CircleCI check's "couldnt find usable config.yml ..." even though the fork has config.yml, does merge cause it or something else, any suggestions?

Hi @ahmet I am note sure what might have happened - we usually rebase the latest changes onto a branch rather than just merging, it helps to keep a clean git history. Perhaps you can reset to the commit prior to the merge and try a rebase? The PR itself looks fine so if that doesn't work let me know and I'll do some digging.

@ahmet
Copy link
Author

ahmet commented Jun 1, 2025

Hi @fainashalts,

I've just rebased on b8beb64 which is the latest of upstream/master atm, CircleCI Pipeline still fails.

Just guessing, it might caused by CircleCI not accessing the public fork of ours.

Screenshot 2025-06-01 at 21 00 45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base PR require review from base team waiting-for-pr-author-response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants