-
Notifications
You must be signed in to change notification settings - Fork 753
update: add optimism and optimism-sepolia addresses for BTREE token #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
update: add optimism and optimism-sepolia addresses for BTREE token #1143
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Not sure why the validate-workflow failed. Let me know if something is malformed in the json or some such, but looks good to me? Leaving the PR here pending feedback in case the CI pipeline is flaky and just needs a kick/re-run or something |
Yeah, I'm not sure what to make of this output from the CI test failing. Not very revealing, but perhaps I'm just looking in the wrong place? @wbnns any advice? Sorry, I know the readme says checks need to pass before a review will be done, but a little unsure what the issue is here: Decided to run the validation locally to see if I could see what's wrong, and came up with this, but ignore me if I'm going down the wrong path: used the 'validate' script in the package.json: ethereum-optimism.github.io/package.json Line 37 in d1e55c7
with the same args as the ci seems to be using --datadir ./data --tokens BTREE/ gets to here in the validate.ts file:
which seems not to match on BTREE/ , so const folders is an empty list.
if I use Checked the validate.ts cli.ts .circleci/config.yaml and package.json with git blame to see if anything that looked relevant had changed recently, but couldn't see anything that likely would've caused an issue. Note: I did also try running the |
Thanks for the reply! Sure, I'll do that. Will @ you once done |
@tremarkley thanks for the feedback! merged instead of rebased, but seems fixed 😄 Apologies if I came off grouchy in my discussion created on the feedback board. I know y'all must be busy, and appreciate the work open source contributors like yourself and @wbnns do. Was just trying to get a resolution. More PRs for same token to more optimism chains incoming 😄 |
Description
Add optimism and optimism-sepolia addresses for BTREE token
Tests
Additional context
Metadata