fix(op-reth): drain Prometheus metric buckets in op-proofs CLI#21596
Merged
Conversation
sebastianst
approved these changes
Jul 6, 2026
einar-oplabs
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During a 1.2 M-block backfill the process RSS grew unboundedly.
AtomicBucketis the in-memory buffer behind every Prometheus histogram emitted by the trie code; it grows on every observation and is only drained byPrometheusHandle::run_upkeep(). paradigmxyz/reth#12283 tracked the same symptom in the node binary and was closed by paradigmxyz/reth#12664, which introducedspawn_upkeep()and called it fromstart_prometheus_endpoint.op-proofsnever reaches that path, so the fix in reth didn't take effect for it.Tests
Additional context
NA
Metadata
Closes #21569