fix(op-preimage): preserve read and write close errors#21597
Open
blackflytech wants to merge 1 commit into
Open
fix(op-preimage): preserve read and write close errors#21597blackflytech wants to merge 1 commit into
blackflytech wants to merge 1 commit into
Conversation
Signed-off-by: blackflytech <blackflytech@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
ReadWritePair.Closeso it preserves close errors from both the reader and writer.Previously, if closing both files failed, the writer close error replaced the reader close error. This change joins each close error into the accumulated error so callers can see both failures.
Tests
go test ./op-preimagegit diff --checkAdditional context
This is a small, focused fix with a regression test. It follows the same low-risk pattern as #21480: narrow scope, clear motivation, and simple local verification.
Metadata