fix(op-reth): install default rustls CryptoProvider for flashblocks TLS#21605
Open
tuan-phan wants to merge 1 commit into
Open
fix(op-reth): install default rustls CryptoProvider for flashblocks TLS#21605tuan-phan wants to merge 1 commit into
tuan-phan wants to merge 1 commit into
Conversation
rustls 0.23 no longer auto-selects a process-level CryptoProvider when
multiple provider features are present in the dependency graph, so op-reth
panics on startup when it opens the flashblocks wss connection:
Could not automatically determine the process-level CryptoProvider
from Rustls crate features.
This kills the flashblocks service, so pre-confirmation RPCs such as
eth_sendRawTransactionSync never receive flashblocks and time out (~30s)
even though the transaction is mined normally.
Install the aws-lc-rs default provider in main() before any TLS is used,
matching reth's default provider selection.
Author
|
@ajsutton Can you have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
op-reth panics on startup when it opens the flashblocks websocket (
wss://) connection:rustls 0.23 no longer auto-selects a process-level
CryptoProviderwhen more than one provider feature is present in the dependency graph. The panic kills the flashblocks service, so pre-confirmation RPCs such aseth_sendRawTransactionSyncnever receive flashblocks and time out (~30s) even though the transaction is mined normally.This installs the
aws-lc-rsdefault provider inmain()before any TLS is used, matching reth's default provider selection.Tests
Built op-reth with this patch and ran it against Unichain mainnet and sepolia. Confirmed:
CryptoProviderpanic on startupeth_sendRawTransactionSyncreturns within pre-confirmation latency instead of timing out after 30sAdditional context
Same root cause and fix as #20145, which was auto-closed as stale. This variant uses the
aws-lc-rsprovider.Metadata
Fixes #19322