Skip to content

fix: Super ZK game QA fixes#21615

Open
0xarktos wants to merge 5 commits into
developfrom
fix/super-zk-game-qa-fixes
Open

fix: Super ZK game QA fixes#21615
0xarktos wants to merge 5 commits into
developfrom
fix/super-zk-game-qa-fixes

Conversation

@0xarktos

@0xarktos 0xarktos commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

QA review fixes for the Super ZK dispute game focusing on natpsec clarifications, a formatting consistency fix, and two new tests. No contract behavior changes.

  • ZKDisputeGame natspec: describe it as a super-roots / interop-ready game, correct the ClaimData slot-packing comments, renumber the CWIA immutable-arg enumeration after l2ChainId was removed, and clarify the resolve() challenger-wins branch (prove deadline expired). Patch semver bump 2.0.02.0.1.
  • LibGameArgs.decodeZK: use a consistent decimal offset in the assembly block.
  • Tests:
    • Round-trip test asserting OPContractsManagerUtils.makeGameArgs output decodes back through LibGameArgs.decodeZK field-for-field.
    • LibClone length-overflow regression test: factory create with oversized extra data must revert for both ZK and super fault games — guards against the Solady CWIA clone-corruption bug if the library version changes. See H-1 in the past audit for details.

Test plan

DEV_FEATURE__ZK_DISPUTE_GAME=true forge test --match-contract "DisputeGameFactory_Create_ZkDisputeGame_Test|OPContractsManagerUtils_MakeGameArgs_Test"

@0xarktos 0xarktos requested review from a team and tynes July 3, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants