fix: Super ZK game QA fixes#21615
Open
0xarktos wants to merge 5 commits into
Open
Conversation
3 tasks
Inphi
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QA review fixes for the Super ZK dispute game focusing on natpsec clarifications, a formatting consistency fix, and two new tests. No contract behavior changes.
ZKDisputeGamenatspec: describe it as a super-roots / interop-ready game, correct theClaimDataslot-packing comments, renumber the CWIA immutable-arg enumeration afterl2ChainIdwas removed, and clarify theresolve()challenger-wins branch (prove deadline expired). Patch semver bump2.0.0→2.0.1.LibGameArgs.decodeZK: use a consistent decimal offset in the assembly block.OPContractsManagerUtils.makeGameArgsoutput decodes back throughLibGameArgs.decodeZKfield-for-field.createwith oversized extra data must revert for both ZK and super fault games — guards against the Solady CWIA clone-corruption bug if the library version changes. See H-1 in the past audit for details.Test plan