op-sepolia: Add task to switch back to singlethreaded cannon. #544
Conversation
Updates the set-game-implementation task to handle recent breaking changes in superchain-registry and the monorepo.
| import {PermissionedDisputeGame} from "@eth-optimism-bedrock/src/dispute/PermissionedDisputeGame.sol"; | ||
| import {SystemConfig} from "@eth-optimism-bedrock/src/L1/SystemConfig.sol"; | ||
|
|
||
| contract NestedSignFromJson is OriginalNestedSignFromJson { |
There was a problem hiding this comment.
Could we use the verification contracts instead, like for many Holocene upgrades?
There was a problem hiding this comment.
Agreed with @sebastianst.
This is easier for us to review and also increase the consistency for the signers + reviewers.
I would suggest to use this as example:
https://github.com/ethereum-optimism/superchain-ops/tree/main/tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain
There was a problem hiding this comment.
This one uses the new DisputeGameUpgrade verification contract.
There was a problem hiding this comment.
Discussed more in discord - this was generated via the standard template for setting dispute games. The verification framework assumes there is permissionless and permissioned game types which isn't always the case so doesn't fit well with the template which can handle all chains. But for this case I've updated the script to use the verification framework.
Description
Add task to switch back to singlethreaded cannon.
Updates the set-game-implementation task to handle recent breaking changes in superchain-registry and the monorepo.