-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate deposit snapshot api #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the one thing is we should probably put in changelog? can then list it'll be removed for fulu fork release.. |
good idea to get more visibility on this, we've missed some more changelog entries #496 |
Due to changes introduced by EIP-6110 this api will no longer be relevant after the Electra hard fork once
state.eth1_deposit_index == state.deposit_requests_start_index
is reached.Deprecating this api as part of the Electra release will allow us to remove it in the Fulu release.