Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate deposit snapshot api #494

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Feb 4, 2025

Due to changes introduced by EIP-6110 this api will no longer be relevant after the Electra hard fork once state.eth1_deposit_index == state.deposit_requests_start_index is reached.

Deprecating this api as part of the Electra release will allow us to remove it in the Fulu release.

@nflaig nflaig added the Electra label Feb 4, 2025
rolfyone
rolfyone previously approved these changes Feb 5, 2025
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfyone
Copy link
Contributor

rolfyone commented Feb 5, 2025

the one thing is we should probably put in changelog? can then list it'll be removed for fulu fork release..

@nflaig
Copy link
Member Author

nflaig commented Feb 6, 2025

the one thing is we should probably put in changelog? can then list it'll be removed for fulu fork release..

good idea to get more visibility on this, we've missed some more changelog entries #496

@rolfyone rolfyone merged commit 1437310 into master Feb 11, 2025
3 checks passed
@rolfyone rolfyone deleted the nflaig/deprecate-deposit-snapshot branch February 11, 2025 02:13
This was referenced Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants