-
Notifications
You must be signed in to change notification settings - Fork 411
execution-apis: Add EIP-7594 (PeerDAS) related changes #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: fradamt <[email protected]>
Co-authored-by: fradamt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve added a few suggestions to slightly improve readability and clarity—mostly minor points for precision. None of them are strictly necessary, so please feel free to accept or ignore them based on your preference!
Co-authored-by: Tei Im <[email protected]>
Co-authored-by: Tei Im <[email protected]>
fix camel case and other small changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a question / request for clarification on the eth_sendRawTransaction
semantics
**Motivation** add `engine_getBlobsV2` to the execution API in preparation for implementation of [distributed blob publishing](https://github.com/ethereum/consensus-specs/blob/dev/specs/fulu/p2p-interface.md#distributed-blob-publishing-using-blobs-retrieved-from-local-execution-layer-client) @dguenther and I wanted to get early feedback on the API change before moving forward with the rest of the implementation **Description** upcoming spec changes will add `engine_getBlobsV2` to the execution API to fetch blobs and cell proofs from the execution layer (ethereum/execution-apis#630) * add `engine_getBlobsV2` to execution API * add type definition for `BlobAndProofV2` **Not included** We'll follow up with additional PR(s) for these as we move forward with distributed blob publishing: * fetch blobs from the EL in two places: on first seen block input gossip and on unknown blocks during syncing * reconstruct blobs from cell proofs * publish data column sidecars on subscribed topics after Relates to #7638 --------- Co-authored-by: Derek Guenther <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the spec point of view the PR looks good to me, great work!
If any detail will be updated or re-shaped, it can be via other PRs
Summary
Introduces updates to rpc and engine API definitions for EIP-7594, changes defined in ethereum/EIPs#9378
Notes for reviewers
This PR introduces backward incompatible changes to
engine_getPayloadV4
, that returns newBlobsBundleV2
with cell proofs instead of blob proofs