core: effectiveTip = GasPrice - BaseFee instead of GasFeeCap - BaseFee
#31771
Conversation
| @@ -532,7 +532,7 @@ func (st *stateTransition) execute() (*ExecutionResult, error) { | |||
|
|
|||
| effectiveTip := msg.GasPrice | |||
| if rules.IsLondon { | |||
| effectiveTip = new(big.Int).Sub(msg.GasFeeCap, st.evm.Context.BaseFee) | |||
| effectiveTip = new(big.Int).Sub(msg.GasPrice, st.evm.Context.BaseFee) | |||
| if effectiveTip.Cmp(msg.GasTipCap) > 0 { | |||
| effectiveTip = msg.GasTipCap | |||
There was a problem hiding this comment.
Can this clause even happen? GasPrice is the effective price paid. In case of EIP-1559, it is a computed value based on GasFeeCap and GasTipCap.
There was a problem hiding this comment.
I'm not sure what exactly you mean by "Can this clause even happen? ", this clause will happen when rules.IsLondon is true, guess you mean something else?
There was a problem hiding this comment.
msg.GasPrice is computed based on GasFeeCap and GasTipCap in case of rules.IsLondon is true.
In this case, the msg.GasPrice is essentially the baseFee + effectiveTip, where the effectiveTip is already capped by the msg.GasTipCap. So the clause below is unnecessary.
There was a problem hiding this comment.
Yes, the clause below is unnecessary, I was planning to remove it after this PR is merged. Do you want to remove it in this PR?
In
buyGas,GasPriceis used to conduct the gas cost.However when computing effectiveTip,
GasFeeCapis used instead.In theory,
GasFeeCap>=GasPrice, so it may happen that the tip fee is larger than it should be.This PR tries to reduce such confusion by computing
effectiveTipbyGasPrice - BaseFeeinstead ofGasFeeCap - BaseFee.Note that for all tx types,
GasFeeCap==GasPricealways holds, so there's no problem for tx. But it's still better to make it consistent .