Skip to content

CI: rename EIP15{0,8} tox jobs to their long-form fork names. #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

veox
Copy link
Contributor

@veox veox commented Jan 7, 2019

What was wrong?

Fallout from PR #1577 (comment).

CI jobs have eip150, eip158 in their names.

One has to know the numbers refer to hard-forks to understand jobs don't check for kitty support, or the like.

How was it fixed?

Renamed CI job name (label only).

(Or was the original request to rename it throughout the codebase?..)

Cute Animal Picture

put a cute animal picture link inside the parentheses

Source: thumbnail of a video on framepool

@veox veox changed the title CI: rename EIP15{0,8} tox jobs to their long-form fork names. [WIP] CI: rename EIP15{0,8} tox jobs to their long-form fork names. Jan 7, 2019
Everywhere else in the codebase, EIP15{0,8} remain.
@veox veox force-pushed the rename-eipxxx-ci-jobs branch from 4e8dc04 to a7f6f92 Compare January 7, 2019 14:48
@veox veox changed the title [WIP] CI: rename EIP15{0,8} tox jobs to their long-form fork names. CI: rename EIP15{0,8} tox jobs to their long-form fork names. Jan 7, 2019
@pipermerriam pipermerriam merged commit caf0869 into ethereum:master Jan 7, 2019
@veox veox deleted the rename-eipxxx-ci-jobs branch April 18, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants