-
Notifications
You must be signed in to change notification settings - Fork 153
feat(era_manager): add era support + pre-fetching #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
4f581fd
2ce7d59
a67027d
66fa50f
350994e
26d145d
5a99d28
e478b71
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,40 +5,10 @@ use rand::{seq::SliceRandom, thread_rng}; | |
use scraper::{Html, Selector}; | ||
use surf::Client; | ||
|
||
const ERA_DIR_URL: &str = "https://mainnet.era.nimbus.team/"; | ||
const ERA1_DIR_URL: &str = "https://era1.ethportal.net/"; | ||
pub const ERA1_FILE_COUNT: usize = 1897; | ||
|
||
/// Fetches era1 files hosted on era1.ethportal.net and shuffles them | ||
pub async fn get_shuffled_era1_files(http_client: &Client) -> anyhow::Result<Vec<String>> { | ||
let index_html = http_client | ||
.get(ERA1_DIR_URL) | ||
.recv_string() | ||
.await | ||
.map_err(|e| anyhow!("{e}"))?; | ||
let index_html = Html::parse_document(&index_html); | ||
let selector = Selector::parse("a[href*='mainnet-']").expect("to be able to parse selector"); | ||
let mut era1_files: Vec<String> = index_html | ||
.select(&selector) | ||
.map(|element| { | ||
let href = element | ||
.value() | ||
.attr("href") | ||
.expect("to be able to get href"); | ||
format!("{ERA1_DIR_URL}{href}") | ||
}) | ||
.collect(); | ||
ensure!( | ||
era1_files.len() == ERA1_FILE_COUNT, | ||
format!( | ||
"invalid era1 source, not enough era1 files found: expected {}, found {}", | ||
ERA1_FILE_COUNT, | ||
era1_files.len() | ||
) | ||
); | ||
era1_files.shuffle(&mut thread_rng()); | ||
Ok(era1_files) | ||
} | ||
|
||
pub fn underlying_io_error_kind(error: &Error) -> Option<io::ErrorKind> { | ||
for cause in error.chain() { | ||
if let Some(io_error) = cause.downcast_ref::<io::Error>() { | ||
|
@@ -48,14 +18,12 @@ pub fn underlying_io_error_kind(error: &Error) -> Option<io::ErrorKind> { | |
None | ||
} | ||
|
||
const ERA_DIR_URL: &str = "https://mainnet.era.nimbus.team/"; | ||
|
||
/// Fetches era file download links | ||
pub async fn get_era_file_download_links( | ||
pub async fn download_era_links( | ||
http_client: &Client, | ||
url: &str, | ||
) -> anyhow::Result<HashMap<u64, String>> { | ||
let index_html = http_client | ||
.get(ERA_DIR_URL) | ||
.get(url) | ||
.recv_string() | ||
.await | ||
.map_err(|e| anyhow!("{e}"))?; | ||
|
@@ -74,12 +42,43 @@ pub async fn get_era_file_download_links( | |
.expect("to be able to get epoch") | ||
.parse::<u64>() | ||
.expect("to be able to parse epoch"); | ||
(epoch_index, format!("{ERA_DIR_URL}{href}")) | ||
(epoch_index, format!("{url}{href}")) | ||
}) | ||
.collect(); | ||
Ok(era_files) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: what do you think about checking that keys are starting from 0 and consecutive? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure what you mean do you want me to loop from 0 to max era count and see if all exist? Because since we are using a hashmap, the the values are stored in the positions of the hash of the keys which wouldn't be in sorted order, if we were to iterate over the buckets in order There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think loop and checking is simple enough. Something like: ensure!(
(0..(era_files.len()).all(|epoch| era_files.contains(&epoch)),
"Epoch indices are not starting from zero or not consecutive",
); You can also calculate min and max and check if they are as desired (this still requires looping, so no saving performance wise). |
||
} | ||
|
||
pub async fn get_era_files(http_client: &Client) -> anyhow::Result<HashMap<u64, String>> { | ||
let era_files = download_era_links(http_client, ERA_DIR_URL).await?; | ||
ensure!(!era_files.is_empty(), "No era files found at {ERA_DIR_URL}"); | ||
ensure!( | ||
(0..era_files.len()).all(|epoch| era_files.contains_key(&(epoch as u64))), | ||
"Epoch indices are not starting from zero or not consecutive", | ||
); | ||
Ok(era_files) | ||
} | ||
|
||
pub async fn get_era1_files(http_client: &Client) -> anyhow::Result<HashMap<u64, String>> { | ||
let era1_files = download_era_links(http_client, ERA1_DIR_URL).await?; | ||
ensure!( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: similar to era files, we can also check that all keys are in the range of |
||
era1_files.len() == ERA1_FILE_COUNT, | ||
format!( | ||
"invalid era1 source, not enough era1 files found: expected {}, found {}", | ||
ERA1_FILE_COUNT, | ||
era1_files.len() | ||
) | ||
); | ||
Ok(era1_files) | ||
} | ||
|
||
/// Fetches era1 files hosted on era1.ethportal.net and shuffles them | ||
pub async fn get_shuffled_era1_files(http_client: &Client) -> anyhow::Result<Vec<String>> { | ||
let era1_files = get_era1_files(http_client).await?; | ||
let mut era1_files: Vec<String> = era1_files.into_values().collect(); | ||
era1_files.shuffle(&mut thread_rng()); | ||
Ok(era1_files) | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use super::*; | ||
|
@@ -94,7 +93,7 @@ mod tests { | |
#[tokio::test] | ||
async fn test_get_era_file_download_links() { | ||
let http_client = Client::new(); | ||
let era_files = get_era_file_download_links(&http_client).await.unwrap(); | ||
let era_files = get_era_files(&http_client).await.unwrap(); | ||
assert!(!era_files.is_empty()); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,13 @@ | ||
use e2store::{ | ||
e2store::types::{Entry, Header as E2StoreHeader}, | ||
era::{get_beacon_fork, CompressedSignedBeaconBlock, Era}, | ||
utils::get_era_file_download_links, | ||
era::{get_beacon_fork, CompressedSignedBeaconBlock, Era, SLOTS_PER_HISTORICAL_ROOT}, | ||
utils::get_era_files, | ||
}; | ||
use revm_primitives::SpecId; | ||
use surf::Client; | ||
|
||
use crate::spec_id::get_spec_block_number; | ||
|
||
use super::{ | ||
constants::FIRST_ERA_EPOCH_WITH_EXECUTION_PAYLOAD, | ||
types::ProcessedEra, | ||
|
@@ -25,14 +28,20 @@ impl EraBinarySearch { | |
http_client: Client, | ||
block_number: u64, | ||
) -> anyhow::Result<ProcessedEra> { | ||
let era_links = get_era_file_download_links(&http_client).await?; | ||
let last_epoch_index = era_links.len() - 1; | ||
if block_number < get_spec_block_number(SpecId::MERGE) { | ||
return Err(anyhow::anyhow!( | ||
"Block number is too low to be in any era file" | ||
)); | ||
} | ||
|
||
let era_links = get_era_files(&http_client).await?; | ||
let mut start_epoch_index = FIRST_ERA_EPOCH_WITH_EXECUTION_PAYLOAD; | ||
let mut end_epoch_index = | ||
*era_links.keys().max().expect("Getting max shouldn't fail") as u64; | ||
let last_epoch_index = end_epoch_index; | ||
|
||
while start_epoch_index <= end_epoch_index { | ||
let mid = end_epoch_index + (start_epoch_index - end_epoch_index) / 2; | ||
let mid = (start_epoch_index + end_epoch_index) / 2; | ||
let mid_block = EraBinarySearch::download_first_beacon_block_from_era( | ||
mid, | ||
era_links[&mid].clone(), | ||
|
@@ -41,7 +50,16 @@ impl EraBinarySearch { | |
.await?; | ||
let mid_block_number = mid_block.block.execution_block_number(); | ||
|
||
// this is an edge case where the block number is in the last era file, we can't check | ||
// mid plus 1 so we just manually check the last era file | ||
if mid + 1 > last_epoch_index as u64 { | ||
let era_to_check = | ||
download_raw_era(era_links[&(mid)].clone(), http_client.clone()).await?; | ||
|
||
let decoded_era = Era::deserialize(&era_to_check)?; | ||
if decoded_era.contains(block_number) { | ||
return process_era_file(era_to_check, mid); | ||
} | ||
return Err(anyhow::anyhow!("Block not found in any era file")); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this isn't true. It can be in the |
||
} | ||
|
||
|
@@ -101,11 +119,15 @@ impl EraBinarySearch { | |
.expect("to be able to download compressed beacon block"); | ||
let entry = Entry::deserialize(&compressed_beacon_block)?; | ||
|
||
let slot_index = (era_index - 1) * 8192; | ||
let slot_index = Self::start_slot_index(era_index); | ||
let fork = get_beacon_fork(slot_index); | ||
|
||
let beacon_block = CompressedSignedBeaconBlock::try_from(&entry, fork)?; | ||
|
||
Ok(beacon_block) | ||
} | ||
|
||
fn start_slot_index(era_index: u64) -> u64 { | ||
(era_index - 1) * SLOTS_PER_HISTORICAL_ROOT as u64 | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.