"Hydrate" the transactions returned by eth_getBlockByHash #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type conversion functions will be reused in several places, and don't belong co-located with the header types.
We should be consistent across all transaction types with the name for this variable. I just picked one, based on the RPC name.
carver
force-pushed
the
eth-get-hydrated-block
branch
from
83c7004 to
6335853
Compare
|
#886 isn't a issue. Maybe the wrong issue was linked? This PR has been open for a year are there any plans to get it past the finish line? If not maybe we should close it and make an issue of the problem (maybe there already is an issue but it isn't linked not sure) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fix #886
How was it fixed?
Aggregate and convert information into the transaction representation. I didn't do a
Fromimplementation, because the jsonrpc representation of a transaction includes block-level information, so we need to compile information from the block and the transaction together first, before converting it into a reth-rpc styleTransaction.To-Do