eth_simulateV1 support
#3622
Merged
eth_simulateV1 support
#3622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [unrelated] Open up the typing for ``StateOverride`` type to match ``to`` and ``from`` keys on ``TxParams``. Accept ``Union[str, Address, ChecksumAddress]`` for these similar types. - Add sync and async ``eth_simulateV1`` RPC methods with integration tests against geth. - Add related types and formatters for ``eth_simulateV1`` RPC method.
fselmo
force-pushed
the
eth_simulatev1-support
branch
from
800ab88 to
e0f7e8b
Compare
fselmo
force-pushed
the
eth_simulatev1-support
branch
from
6abad0e to
2c48d3a
Compare
kclowes
approved these changes
Feb 19, 2025
I did have it like that in the beginning and figured I'd copy the endpoint name but we do have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Though ethereum/execution-apis#484 has not yet been merged, many clients have already implemented
eth_simulateV1. This PR adds support foreth_simulateV1RPC endpoint requests with formatters and expected types.Closes #3494
How was it fixed?
eth_simulateV1support forethandasync_ethStateOverridetype keys to better matchTxParams: acceptsstrandAddressin addition toChecksumAddress. We already use formatters that turn these values into the checksum address.Todo:
Cute Animal Picture