Skip to content

Implement EIP-4803 (Limit Tx Gas)#3827

Draft
jochem-brouwer wants to merge 4 commits into
masterfrom
eip-4803
Draft

Implement EIP-4803 (Limit Tx Gas)#3827
jochem-brouwer wants to merge 4 commits into
masterfrom
eip-4803

Conversation

@jochem-brouwer
Copy link
Copy Markdown
Member

Closes #3825

@jochem-brouwer jochem-brouwer added PR state: WIP package: tx type: test all hardforks This special label enables VM state and blockchain tests for all hardforks on the respective PR. labels Dec 22, 2024
@jochem-brouwer
Copy link
Copy Markdown
Member Author

Running all hardforks because I think ethereum/tests might not have implemented this (and instead checked original limit of 2^64-1)

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 22, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.32%. Comparing base (50d121a) to head (8a815e0).
⚠️ Report is 276 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 76.87% <ø> (ø)
blockchain 85.69% <ø> (ø)
client 66.26% <ø> (ø)
common 90.72% <ø> (ø)
devp2p 76.27% <ø> (ø)
ethash 81.04% <ø> (ø)
evm 69.39% <ø> (ø)
genesis 99.84% <ø> (ø)
mpt 59.95% <ø> (ø)
rlp 69.70% <ø> (ø)
statemanager 70.15% <ø> (ø)
tx ?
util 85.17% <100.00%> (+<0.01%) ⬆️
vm 57.81% <ø> (ø)
wallet 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jochem-brouwer
Copy link
Copy Markdown
Member Author

Ok, this is not supported by ethereum/tests but rather in the TransactionTests, see:

https://github.com/ethereumjs/ethereumjs-monorepo/actions/runs/12450447293/job/34757292887?pr=3827

Errors for instance:

     → RLP is valid, but decoding failed
   × TransactionWithHighGasLimit64Minus1 > TransactionWithHighGasLimit64Minus1 [shanghai]

@gabrocheleau
Copy link
Copy Markdown
Contributor

Wondering if this could get finalized/merged @jochem-brouwer ?

@jochem-brouwer
Copy link
Copy Markdown
Member Author

I believe this has no consensus yet ecosystem wide, which I think is why I kept this open as draft. I'll check what the status of this is, I think we have no max nonce yet set (it is uint64, but this off-by-one might not yet be the broad consensus)

@holgerd77 holgerd77 changed the title Implement EIP-4803 Implement EIP-4803 (Limit Tx Gas) Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: tx PR state: WIP type: test all hardforks This special label enables VM state and blockchain tests for all hardforks on the respective PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement EIP-4803 (Limit Tx Gas)

3 participants