looks like locate file was the issue

[n8wb]

• Update to vitest v4
• Make locateFile undefined when it is the browser version
• Tested this with Update kzg-wasm ethereumjs-monorepo#4169 by injecting the new version and the tests passed

[holgerd77]

🙏 🙏 🙏 🙏 🙏

[holgerd77]

Hmm, tests are now timing out for me locally:

Any idea what's happening?

[holgerd77]

(so: the test directly here on the library, not the ones over on the monorepo)

[holgerd77]

Ah, and this we need to fix as well, we can't have this as a production dependency. I can do along release though.

[holgerd77]

Anyhow: have increased the timeout

[holgerd77]

Have released as rc.4 and updated ethereumjs/ethereumjs-monorepo#4169 along.

[holgerd77]

Ok, works, super great! 💯

I won't ask for any optimizations anymore for now, but one last question, since this is the "core of it all":

So, are you really sure/confident that this (the whole library) makes things a lot faster in production? So at least on the testing side, things are dramatically slow compared to the JS version.

So and if proof verification is faster: have you got some (very rough) ballpark numbers how much faster this is compared to the JS version (did you try the JS version?)? Because if we are not confident here, the selling point is rather gone (likely for yourself as well).

[n8wb]

Ok, works, super great! 💯

I won't ask for any optimizations anymore for now, but one last question, since this is the "core of it all":

So, are you really sure/confident that this (the whole library) makes things a lot faster in production? So at least on the testing side, things are dramatically slow compared to the JS version.

So and if proof verification is faster: have you got some (very rough) ballpark numbers how much faster this is compared to the JS version (did you try the JS version?)? Because if we are not confident here, the selling point is rather gone (likely for yourself as well).

This is the average time over 30 runs each, run in the same way as the tests in the ethereumjs-monorepo (so running in chrome essentially to make it a fair comparison)

WASM KZG: 27.866666666666667 ms per commitment
JS KZG: 4.466666666666667 ms per commitment
WASM KZG: 276.06666666666666 ms per proof
JS KZG: 644.7666666666667 ms per proof
WASM KZG: 12.233333333333333 ms per verify proof
JS KZG: 28.333333333333332 ms per verify proof

[holgerd77]

@n8wb Have published https://github.com/ethereumjs/kzg-wasm/releases/tag/kzg-wasm%401.0.0, thanks a lot again! 🙏