Make header proof validation optional in addRLPSerializedBlock
#604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick follow-on to #603 to make sure we don't break current RPC scripts related to loading blocks locally with
addRLPSerializedBlock. This utility is non-standard anyway so not a huge deal but logically inconsistent since we should "never" accept pre-merge headers without a proof anymore. We just don't store all the accumulators locally to be able to construct them on the fly.A full solution would involve updating the bridge scripts for pre-merge blocks to construct the header proofs and then load them that way.