-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vitest to v3.0.2 #715
Conversation
The coverage was failing at the reference of |
exclude: [ | ||
'test/integration', | ||
'test/networks/history/portalSpecTests.spec.ts', | ||
'test/networks/state/content.spec.ts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these new exclusions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you just needed to run git submodule -- init
or something. They all are passing locally for me so I'm going to revert this change.
Vitest just got an update to 3.0.x so it might be worth immediately updating to that :) |
I second this! |
I'm not 100% sure what's going on but now when I run the tests locally, some of them hang. We might need to do some more research on why they're hanging before we upgrade. I'll put this on my todo list for next week. @cjustinobi could you go ahead and update to vitest v3 like @jochem-brouwer suggested and then we can just do this upgrade once, once we figure out why tests are hanging. |
It seems the issue is coming from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Changes
vitest
and@vitest/ui
dependency to ^3.0.2.@vitest/coverage-v8
for test coveragetest:ui
script for web view of the coverage