Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vitest to v3.0.2 #715

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Conversation

cjustinobi
Copy link
Contributor

@cjustinobi cjustinobi commented Jan 17, 2025

Changes

  • Updated vitest and @vitest/ui dependency to ^3.0.2.
  • Added @vitest/coverage-v8 for test coverage
  • Added test:ui script for web view of the coverage

@cjustinobi
Copy link
Contributor Author

The coverage was failing at the reference of portal-spec-tests submodule. Had to exclude
it for the time being.

exclude: [
'test/integration',
'test/networks/history/portalSpecTests.spec.ts',
'test/networks/state/content.spec.ts',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these new exclusions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you just needed to run git submodule -- init or something. They all are passing locally for me so I'm going to revert this change.

@jochem-brouwer
Copy link
Member

Vitest just got an update to 3.0.x so it might be worth immediately updating to that :)

@ScottyPoi
Copy link
Collaborator

Vitest just got an update to 3.0.x so it might be worth immediately updating to that :)

I second this!

@acolytec3
Copy link
Collaborator

acolytec3 commented Jan 18, 2025

I'm not 100% sure what's going on but now when I run the tests locally, some of them hang. We might need to do some more research on why they're hanging before we upgrade. I'll put this on my todo list for next week.

@cjustinobi could you go ahead and update to vitest v3 like @jochem-brouwer suggested and then we can just do this upgrade once, once we figure out why tests are hanging.

@cjustinobi
Copy link
Contributor Author

I'm not 100% sure what's going on but now when I run the tests locally, some of them hang. We might need to do some more research on why they're hanging before we upgrade. I'll put this on my todo list for next week.

@cjustinobi could you go ahead and update to vitest v3 like @jochem-brouwer suggested and then we can just do this upgrade once, once we figure out why tests are hanging.

It seems the issue is coming from packages/portalnetwork/test/integration/eth/getBlockByNumber.spec.ts

Copy link
Collaborator

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 changed the title Update vitest to v2.1.8 Update vitest to v3.0.2 Jan 22, 2025
@acolytec3 acolytec3 merged commit 29a7f29 into ethereumjs:master Jan 22, 2025
5 checks passed
Copy link
Collaborator

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@acolytec3 acolytec3 mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants