Network Census #727
Closed
Network Census #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolytec3
reviewed
Feb 4, 2025
| /** | ||
| * Map of all known peers in the network | ||
| */ | ||
| public networkCensus: Map<string, ScoredPeer> |
There was a problem hiding this comment.
Suggested change
| public networkCensus: Map<string, ScoredPeer> | |
| public networkCensus: Map<NodeId, ScoredPeer> |
Import NodeId from @chainsafe/enr
|
closing to combine with #726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introdueces a new mapping in the
RoutingTableclass which track the client info from Ping/Pong payloads.The network census tracks all known nodes in the network, not just nodes in the kademlia routing table, which has bucket size limits.
A new class called ScoredPeer was created for this mapping. The currently implementation of ScoredPeer stores minimal information, but the class could be used in future updates to track different metrics or history.