Return ephemeral headers in FOUNDCONTENT #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottyPoi
approved these changes
Feb 28, 2025
| @@ -34,7 +34,7 @@ export const MICROSECOND_WAIT_BETWEEN_BURSTS: number = 28000 | |||
| export const TIME_WAIT_AFTER_LAST_PACKET: number = 3000000 | |||
| export const ONLY_POSITIVE_GAIN: boolean = false | |||
| export const DEBUG: boolean = false | |||
| export const MAX_UTP_PACKET_LENGTH = MAX_PACKET_SIZE | |||
| export const MAX_UTP_PACKET_LENGTH = MAX_UDP_PACKET_SIZE | |||
There was a problem hiding this comment.
This feels wrong, or useless. I assume we meant to limit the size of the UTP packet to the max size of a UDP payload -- which would be something like MAX_UDP_PACKET_SIZE - MAX_UDP_HEADER_LENGTH
There was a problem hiding this comment.
Oh, you're right 🤦 It should be MAX_UDP_PACKET_SIZE - TALKREQOVERHEAD - utp packet metadata. Let me shamelessly rip that from fluffy too since they already worked out the math.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues work on #741
BiMapclass for the ephemeral headers index