Skip to content

keep #startBlock when creating a TransactionResponse from a TransactionResponse #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib.commonjs/providers/provider.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib.commonjs/providers/provider.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib.esm/address/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* Addresses are a fundamental part of interacting with Ethereum. They
* represent the gloabal identity of Externally Owned Accounts (accounts
* represent the global identity of Externally Owned Accounts (accounts
* backed by a private key) and contracts.
*
* The Ethereum Naming Service (ENS) provides an interconnected ecosystem
Expand Down
2 changes: 1 addition & 1 deletion lib.esm/address/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib.esm/contract/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import type { ContractTransactionResponse } from "./wrappers.js";
*
* [[DeferredTopicFilter]] - A filter created by calling a [[ContractEvent]]
* with parameters, which will create a filter for a specific event
* signautre and dereference each parameter when calling the listener.
* signature and dereference each parameter when calling the listener.
*/
export type ContractEventName = string | ContractEvent | TopicFilter | DeferredTopicFilter;
/**
Expand Down
2 changes: 1 addition & 1 deletion lib.esm/crypto/signature.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export type SignatureLike = Signature | string | {
export declare class Signature {
#private;
/**
* The ``r`` value for a signautre.
* The ``r`` value for a signature.
*
* This represents the ``x`` coordinate of a "reference" or
* challenge point, from which the ``y`` can be computed.
Expand Down
2 changes: 1 addition & 1 deletion lib.esm/crypto/signature.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib.esm/crypto/signing-key.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions lib.esm/providers/community.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
*/
export interface CommunityResourcable {
/**
* Returns true of the instance is connected using the community
* Returns true if the instance is connected using the community
* credentials.
*/
isCommunityResource(): boolean;
}
/**
* Displays a warning in tht console when the community resource is
* Displays a warning in the console when the community resource is
* being used too heavily by the app, recommending the developer
* acquire their own credentials instead of using the community
* credentials.
Expand Down
2 changes: 1 addition & 1 deletion lib.esm/providers/community.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib.esm/providers/provider.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export interface PreparedTransactionRequest {
*/
nonce?: number;
/**
* The maximum amount of gas to allow this transaction to consime.
* The maximum amount of gas to allow this transaction to consume.
*/
gasLimit?: bigint;
/**
Expand Down
2 changes: 1 addition & 1 deletion lib.esm/providers/provider.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib.esm/providers/provider.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src.ts/providers/provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1410,7 +1410,7 @@ export class TransactionResponse implements TransactionLike<string>, Transaction
this.accessList = (tx.accessList != null) ? tx.accessList: null;
this.blobVersionedHashes = (tx.blobVersionedHashes != null) ? tx.blobVersionedHashes: null;

this.#startBlock = -1;
this.#startBlock = (tx instanceof TransactionResponse) ? tx.#startBlock : -1;
}

/**
Expand Down