Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor+improvements #20

Merged
merged 4 commits into from
Apr 30, 2018
Merged

Refactor+improvements #20

merged 4 commits into from
Apr 30, 2018

Conversation

kumavis
Copy link
Contributor

@kumavis kumavis commented Apr 29, 2018

  • rewrite tests to use async/await
  • refactor index based on @danfinlay's work
  • move tests to ganache-core

Fixes #4

@kumavis
Copy link
Contributor Author

kumavis commented Apr 29, 2018

weird travis seems to have ignored my node_js flag?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d35e0e9 on kumavis:refactor+improvements into 4efdbc2 on ethjs:master.

@kumavis
Copy link
Contributor Author

kumavis commented Apr 29, 2018

weird, seems like it got my node_js flag the second time

@SilentCicero
Copy link
Member

Will review again and most likely push early next week @kumavis

@SilentCicero SilentCicero merged commit d06b9e4 into ethjs:master Apr 30, 2018
@kumavis kumavis deleted the refactor+improvements branch April 30, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumavis @coveralls @SilentCicero