fix for intToBuffer method #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will review, thanks!
…Sent from my iPhone
On Jun 8, 2018, at 9:56 AM, Coveralls ***@***.***> wrote:
Coverage remained the same at 100.0% when pulling 951e383 on vpulim:fix-int-to-buffer into e1ea887 on ethjs:master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Can you describe where and how you are using this module, it would be helpful.
…Sent from my iPhone
On Jun 8, 2018, at 9:56 AM, Coveralls ***@***.***> wrote:
Coverage remained the same at 100.0% when pulling 951e383 on vpulim:fix-int-to-buffer into e1ea887 on ethjs:master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@SilentCicero This module is used in ethereumjs-util to convert integers to Buffers (https://github.com/ethereumjs/ethereumjs-util/blob/master/index.js#L170). Its also used in tests for ethereumjs-blockchain (https://github.com/ethereumjs/ethereumjs-blockchain/blob/master/test/index.js#L61). However, simply calling intToBuffer() on ethjs-util fails when you pass in an integer < 16 (it returns an empty Buffer) |
|
This was due to the previous PR, okay, lets patch it then, thanks!
…On Fri, Jun 8, 2018 at 10:59 AM, Vinay Pulim ***@***.***> wrote:
@SilentCicero <https://github.com/SilentCicero> This module is used in
ethereumjs-util to convert integers to Buffers (https://github.com/
ethereumjs/ethereumjs-util/blob/master/index.js#L170). Its also used in
tests for ethereumjs-blockchain (https://github.com/ethereumjs/ethereumjs-
blockchain/blob/master/test/index.js#L61).
However, simply calling intToBuffer() on ethjs-util fails when you pass in
an integer < 16.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJWhXhFLp3-QCQNcWzFRWg7x2XatLUZNks5t6pE4gaJpZM4UgQWi>
.
|
|
Great! Thanks |
|
@vpulim should be up in NPM [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #8
In the intToBuffer() method, we now call padToEven() on the hex string generated by intToHex() to ensure the new Buffer object can parse the hex string correctly.
NOTE: This fix is compatible with PR #7 and still maintains the fix for issue #6