Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action center: add consent category editing #5739

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Feb 6, 2025

Closes HA-369

Description Of Changes

Adds consent category editing cell to action center asset view and bulk-add modal to table.

Screenshot 2025-02-05 at 17 58 39

Screenshot 2025-02-05 at 17 59 09

Steps to Confirm

  1. Checkout and run the backend from Adam's branch in the fidesplus repo (asachs/HJ-295).
  2. Run turbo dev from the clients directory
  3. Visit AdminUI's "About" page and enable the new "Website Monitor" feature flag
  4. Click the "Action center" left nav item
  5. If you receive a message here saying it's disabled, contact Adam to update config.
  6. You should see 2 monitors, which are just dummy data from Adam's BE at the moment.
  7. Click into a monitor by clicking the row or the "Review" button
  8. Click into a system by clicking its row on the table
  9. Assets within the system should have a cell that can be used to add or remove consent categories
  10. Select multiple assets using the checkboxes
  11. In the "Actions" menu click "Add consent category"
  12. Should be able to add a consent category to all selected assets

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 2:38am

Copy link

cypress bot commented Feb 6, 2025

fides    Run #12193

Run Properties:  status check passed Passed #12193  •  git commit 269eeb6a29 ℹ️: Merge 9c464fd08dc9e5fb1cb95daef8f1835d3b417b97 into c487c32153aeebe1fe17fd829142...
Project fides
Branch Review refs/pull/5739/merge
Run status status check passed Passed #12193
Run duration 00m 48s
Commit git commit 269eeb6a29 ℹ️: Merge 9c464fd08dc9e5fb1cb95daef8f1835d3b417b97 into c487c32153aeebe1fe17fd829142...
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant