Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action center: Bulk add/ignore system UI #5740

Merged
merged 7 commits into from
Feb 7, 2025

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Feb 6, 2025

Closes HA-403

Description Of Changes

Adds row selection and bulk actions menu to aggregate system results table to enable bulk adding/ignoring resources by system.

Screenshot 2025-02-06 at 16 40 48

Code Changes

  • Changes to add/ignore queries to accept a list of system IDs instead of a single one

Steps to Confirm

  1. Run Fidesplus backend on this branch.
  2. View aggregate system results table
  3. Should be able to individually add and ignore systems from the table row
  4. Select "Uncategorized assets" and some other rows, then click "Actions" menu
  5. "Add" option should be disabled with tooltip; should be able to click "Ignore" to ignore all selected
  6. Select some systems not including "Uncategorized", then click "Actions" menu
  7. Should be able to click "Add" to add all selected

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 4:24pm

Copy link

cypress bot commented Feb 6, 2025

fides    Run #12228

Run Properties:  status check passed Passed #12228  •  git commit 1a847dd1fa ℹ️: Merge eb4987e80ace7f7105cab086f8e48ea5129fa24b into cc24c565881f3cbc4eec3952e344...
Project fides
Branch Review refs/pull/5740/merge
Run status status check passed Passed #12228
Run duration 00m 48s
Commit git commit 1a847dd1fa ℹ️: Merge eb4987e80ace7f7105cab086f8e48ea5129fa24b into cc24c565881f3cbc4eec3952e344...
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@andres-torres-marroquin
Copy link
Contributor

Looks good to me! Ship it!

@jpople jpople merged commit c9ea54c into main Feb 7, 2025
20 checks passed
@jpople jpople deleted the jpople/ha-403/bulk-add-ignore-systems branch February 7, 2025 16:44
Copy link

cypress bot commented Feb 7, 2025

fides    Run #12232

Run Properties:  status check passed Passed #12232  •  git commit c9ea54cc98: Action center: Bulk add/ignore system UI (#5740)
Project fides
Branch Review main
Run status status check passed Passed #12232
Run duration 00m 47s
Commit git commit c9ea54cc98: Action center: Bulk add/ignore system UI (#5740)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants