Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala3-library, ... to 3.3.5 #1303

Merged

Conversation

scala-steward
Copy link
Contributor

@scala-steward scala-steward commented Feb 3, 2025

About this PR

πŸ“¦ Updates

from 3.3.4 to 3.3.5

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:semver-spec, commit-count:n:2

Summary by CodeRabbit

  • Chores
    • Upgraded build dependencies to enhance performance and reliability in our development process.

Copy link

coderabbitai bot commented Feb 3, 2025

Walkthrough

The pull request updates the Scala version from 3.3.4 to 3.3.5. The change is applied in two places: the CI workflow configuration under .github/workflows/ci.yml, where both the build and publish jobs' matrices are updated, and the build.sbt file where the Scala version constant is revised. No modifications to error handling, control flow, or public API declarations are included.

Changes

File(s) Change Summary
.github/workflows/ci.yml Updated Scala version from 3.3.4 to 3.3.5 in build and publish jobs.
build.sbt Revised Scala version constant from "3.3.4" to "3.3.5".

Poem

In lines of code I softly hop,
Upgrading Scala without a stop.
CI jobs and builds now shine so bright,
With every update, all feels right.
A rabbit sings of code delight!


πŸ“œ Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between a1ed457 and d41ac60.

πŸ“’ Files selected for processing (2)
  • .github/workflows/ci.yml (2 hunks)
  • build.sbt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test (ubuntu-latest, 3.3.5, temurin@18)
πŸ”‡ Additional comments (3)
build.sbt (1)

41-41: LGTM! Version update looks good.

The Scala version update from 3.3.4 to 3.3.5 is correctly applied and properly referenced throughout the build configuration.

βœ… Verification successful

Scala Version Update Consistency Verified

The update to Scala version 3.3.5 in build.sbt is properly applied. The only match for "3.3.4" was found in a resource file (guide/src/test/resources/fonts/glyphicons-halflings-regular.svg), which does not impact build configuration. The release tag check confirms that version 3.3.5 exists.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the Scala version is consistently used across the project

# Check for any hardcoded old versions
rg -l "3.3.4"

# Check if the new version exists in the Scala releases
curl -s "https://api.github.com/repos/scala/scala3/releases/tags/3.3.5" | jq -r '.tag_name'

Length of output: 173

.github/workflows/ci.yml (2)

26-26: LGTM! CI workflow version is aligned.

The Scala version in the CI workflow matrices is correctly updated to match the build.sbt configuration.

Also applies to: 62-62


1-6: Note: This is an auto-generated file.

As mentioned in the header comments, this file should not be edited manually. Any changes should be made through the sbt build configuration.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@etorreborre etorreborre merged commit 9ad23d3 into etorreborre:main Feb 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants