Feature: RQES Redesign #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ides selection of qtsp service, certificate and info of the selected document, work in progress. OptionsSelection screen was created that will allow selecting QTSP and certificate for signing a document. ModalOptionUi was adjusted to support leading and trailing icon. Bottom sheet for qtsp was modified to also include action buttons at the bottom, item selection is applied on done click. Icons, localized texts and other resources were imported, corrections on unit tests. Signed-off-by: Christos Kaitatzis <[email protected]>
…teractor, currentScreenSelectionState value was set in viewmodel to determine state of the screen, when certificate is selected the Continue button will be displayed, adjsutements in bottom sheets shown in QTSP and certificate celection step, wordings set in localizable keys, wip Signed-off-by: Christos Kaitatzis <[email protected]>
# Conflicts: # rqes-ui-sdk/src/main/java/eu/europa/ec/eudi/rqesui/presentation/ui/select_certificate/SelectCertificateScreen.kt
Modifications in SelectionOptionUi model to act as a generic UI option model that can carry an event, using it to define the items for document, qtsp and certificate selection. Equivalent modifications in Success screen, also using now the ContentHeader. Imported WrapImage, WrapText, AppIconAndText, RelyingParty components. LocalizableKey updated with new wordings. Drawables and text resources for content description added. Signed-off-by: Christos Kaitatzis <[email protected]>
…, corrections in OptionsSelectionViewModel, removed unused localizable keys. Signed-off-by: Christos Kaitatzis <[email protected]>
As the interactor responsible for qtsp and certificate functionality is now OptionsSelectionInteractor, TestOptionsSelectionInteractor will now contain the test cases placed at TestSelectQtspInteractor and TestSelectCertificateInteractor. View model tests commented out temporarily. Signed-off-by: Christos Kaitatzis <[email protected]>
…onsSelection view model, adjustments and improvements in TestSuccessViewModel Signed-off-by: Christos Kaitatzis <[email protected]>
Call modifieed in OptionsSelectionInteractor to only retrieve selected QTSP and not both file and qtsp as it is not needed at that step. TestOptionsSelectionViewModel created with tests targeting high coverage and test cases commenting, previous test classes removed. Signed-off-by: Christos Kaitatzis <[email protected]>
…imports, corrected name of options selection view model test Signed-off-by: Christos Kaitatzis <[email protected]>
…ent type, removed maxLines on mainText of SelectionItem to avoid hiding info from to user while selecting options Signed-off-by: Christos Kaitatzis <[email protected]>
…fter a check for content not being null in GenericBaseSheetContent, the two buttons are set to be displayed independently when button text for positive or negative action is not null, to support showing one option also, removed unused function Signed-off-by: Christos Kaitatzis <[email protected]>
MultiRowToolbar was created in order to place toolbar title in ViewDocument screen at a different row, also supports two lines of text with ellipsis, correction in OptionsSelectionViewModel on the qtspServiceSelectionItem icon tint . Signed-off-by: Christos Kaitatzis <[email protected]>
Signed-off-by: Christos Kaitatzis <[email protected]>
…electToolbar function in ContentScreen should take into consideration the contentErrorConfig properties Signed-off-by: Christos Kaitatzis <[email protected]>
- OptionsSelectionUiConfig now has a sealed interface to distinguish between its possible states. - SelectionItem composable reworked. Also, it is no longer used from the Success Screen as well. A new composable was introduced for its purposes. - ViewDocumentScreen UI adjusted to correctly show its Title. - Various UI fixes in some composables to be according to the designs. - Removed some unused files from the project. - Adjusted unit tests.
gstamatop
approved these changes
Feb 18, 2025
stzouvaras
approved these changes
Feb 18, 2025
stzouvaras
merged commit 849e243
into
eu-digital-identity-wallet:main
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
RQES document signing flow redesign
Issue: #48
Applied UI modifications according to latest design for the document, QTSP and certificate selection flow. Key changes include:
Additional refinements include adjustments to bottom sheets, updating UI in Success screen, cleanup (removing unused states, localizable keys, unnecessary functions)
Checklist: