Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: UI Adjustments to Support dynamic TopAppBar #51

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

stzouvaras
Copy link
Member

@stzouvaras stzouvaras commented Feb 21, 2025

Description of changes

Refactor: Removed ContentTitle Composable and updated UI

  • Removed the ContentTitle composable and integrated its functionality into ErrorTitle in ContentError.
  • Updated ViewDocumentScreen to use a Box layout for better content management.
  • Adjusted ViewDocumentScreen to leverage MediumTopAppBar when a title is present.
  • Refactored ContentScreen to utilize MediumTopAppBar and dynamically show or hide title based on the state.
  • Added ContentErrorConfig for error display.
  • Replaced ContentTitle with ErrorTitle in OptionsSelectionScreen.
  • Updated version to 0.1.4.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other fix (maintenance or house-keeping)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test suite run successfully
  • Added Tests ()

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked that my views are accessible
  • I have checked that my strings are localized where applicable

- Removed the `ContentTitle` composable and integrated its functionality into `ErrorTitle` in `ContentError`.
- Updated `ViewDocumentScreen` to use a `Box` layout for better content management.
- Adjusted `ViewDocumentScreen` to leverage `MediumTopAppBar` when a title is present.
- Refactored `ContentScreen` to utilize `MediumTopAppBar` and dynamically show or hide title based on the state.
- Added `ContentErrorConfig` for error display.
- Replaced `ContentTitle` with `ErrorTitle` in `OptionsSelectionScreen`.
- Updated version to `0.1.4`.
@stzouvaras stzouvaras requested a review from a team as a code owner February 21, 2025 20:52
@stzouvaras stzouvaras merged commit 84c7f14 into eu-digital-identity-wallet:main Feb 21, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant