transaction_data support
#307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babisRoutis
reviewed
Jan 29, 2025
babisRoutis
reviewed
Jan 29, 2025
babisRoutis
requested changes
Jan 29, 2025
src/main/kotlin/eu/europa/ec/eudi/openid4vp/internal/request/RequestObjectResolver.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/eu/europa/ec/eudi/openid4vp/internal/request/RequestObjectResolver.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/eu/europa/ec/eudi/openid4vp/internal/request/RequestObjectResolver.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/eu/europa/ec/eudi/openid4vp/internal/request/RequestObjectResolver.kt
Outdated
Show resolved
Hide resolved
babisRoutis
previously approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Dear @dzarras
Redefined the TransactionData to hold a JsonObject instead of the base64 representation of it.
Please recheck this a if you can check also my other comment about tests
src/test/kotlin/eu/europa/ec/eudi/openid4vp/UnvalidatedRequestResolverTest.kt
Show resolved
Hide resolved
…ad of the deserialized jsonobject.
dzarras
force-pushed
the
feat/transaction-data
branch
from
f131732 to
a67f02e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #306