Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in tcg_gen_not_vec operation. #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −5
Open

Fix a bug in tcg_gen_not_vec operation. #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions tcg/tcg-op-vec.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,11 +590,17 @@ void tcg_gen_eqv_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b)

void tcg_gen_not_vec(unsigned vece, TCGv_vec r, TCGv_vec a)
{
if (TCG_TARGET_HAS_not_vec) {
vec_gen_op2(INDEX_op_not_vec, 0, r, a);
} else {
/* TODO (SymQEMU):
* This instruction is not instrumented yet.
* For now, we make sure that alternative instructions below, which are instrumented, are always used.
* Directly instrumenting this instruction would improve performance of SymQEMU.
*/

// if (TCG_TARGET_HAS_not_vec) {
// vec_gen_op2(INDEX_op_not_vec, 0, r, a);
// } else {
tcg_gen_xor_vec(0, r, a, tcg_constant_vec_matching(r, 0, -1));
}
// }
}

void tcg_gen_neg_vec(unsigned vece, TCGv_vec r, TCGv_vec a)
Expand All @@ -611,7 +617,6 @@ void tcg_gen_neg_vec(unsigned vece, TCGv_vec r, TCGv_vec a)
* Directly instrumenting this instruction would improve performance of SymQEMU.
*/


/*if (!TCG_TARGET_HAS_neg_vec || !do_op2(vece, r, a, INDEX_op_neg_vec)) {*/
tcg_gen_sub_vec(vece, r, tcg_constant_vec_matching(r, vece, 0), a);
/*}*/
Expand Down