Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed 'gridWidth' bug #12

Merged
merged 1 commit into from
Dec 20, 2017
Merged

fixed 'gridWidth' bug #12

merged 1 commit into from
Dec 20, 2017

Conversation

mrtanweijie
Copy link
Contributor

No description provided.

@euvl
Copy link
Owner

euvl commented Dec 19, 2017

What was the bug ? 😄

@mrtanweijie
Copy link
Contributor Author

I found gridResponsiveWidth never been used in the code . So when I use the gridWidth it did not effective , the value of rowCount ( and rowShift) still count by the windowWidth 😄

@euvl
Copy link
Owner

euvl commented Dec 20, 2017

Cool, great work!

@euvl euvl merged commit 72cc708 into euvl:master Dec 20, 2017
@euvl
Copy link
Owner

euvl commented Dec 20, 2017

I ll test it on the weekends tho

@ossipov ossipov mentioned this pull request Jun 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrtanweijie @euvl