feat(core): add messageBus and workflowEngine to container_type enum#2493
Open
Vinceveve wants to merge 1 commit into
Open
feat(core): add messageBus and workflowEngine to container_type enum#2493Vinceveve wants to merge 1 commit into
messageBus and workflowEngine to container_type enum#2493Vinceveve wants to merge 1 commit into
Conversation
Adds two values to the `container-type` enum so message brokers (Kafka, NATS, RabbitMQ, SQS/SNS, Pub/Sub) and workflow engines (Temporal, Airflow, Step Functions) can be classified as first-class C4 containers instead of falling back to `externalSaaS` or `other`. Refs: event-catalog#2492 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 7b7b452 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
Hey @Vinceveve I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2492.
Adds two values to the
container-typeenum so message brokers (Kafka, NATS, RabbitMQ, SQS/SNS, Pub/Sub) and workflow engines (Temporal, Airflow, Step Functions) can be classified as first-class C4 containers instead of falling back toexternalSaaSorother. Purely additive — no existing values renamed, no behavior change for existing catalogs.Opening as draft pending the discussion in #2492; happy to adjust naming or wait on RFC #1819 if maintainers prefer.
Changes
packages/core/eventcatalog/src/content.config.tspackages/linter/src/schemas/data-store.ts,packages/linter/tests/schema-validator.test.tspackages/sdk/src/types.d.tsast.ts/grammar.ts/tmLanguage.json+ parsing tests:packages/language-server/08-container.md,18-grammar.md,SPEC.md,dsl-spec.md,databases.mdxpackages/language-server/src/completion-data.ts,packages/playground/src/monaco/ec-language.tspackages/visualiser/src/nodes/data/DataNode.tsxpackages/vscode-extension/syntaxes/ec.tmLanguage.jsonTest plan
pnpm --filter @eventcatalog/language-server run test— 417 passed (added 2 new parsing cases)pnpm --filter @eventcatalog/linter run test tests/schema-validator.test.ts— 20 passed (addedit.eachfor the two new values)pnpm run formatcleanmessageBusvsmessageBrokervseventStream;workflowEnginevsworkflowOrchestrator)