Ensured isolation between the single writer SQLite transactions#185
Merged
Conversation
c3b39b5 to
340f7be
Compare
340f7be to
ac0f28e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
sqliteis async and missing MVCC in SQLite (different model, message loop), then we can't rely on commands being run sequentially for the shared connection. We do that for the SQLite3 wrapper to improve write performance. This caused several issues:Besides that, there may be edge cases where multiple nested transactions were opened in the same nested connection, then they weren't correctly disposed of.
Fixed those issues by ensuring that reentrance of the critical section (so acccesing transaction) will be detected for the same section and fixing the nested transaction disposal.