Disabled minifying for cjs, as it seems that's breaking the build

event-driven-io · Oct 25, 2024 · 206ad6a · 206ad6a
1 parent a2c8145
commit 206ad6a
Show file tree

Hide file tree

Showing 21 changed files with 320 additions and 180 deletions.
diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
@@ -83,9 +83,9 @@ jobs:
             echo "No errors found, proceeding..."
           fi
 
-      - name: Use Emmett shims in the browser compatibility test project
-        working-directory: ./src/e2e/browser
-        run: npm install ../esmCompatibility/${{ env.PACKAGE_FILENAME_SHIMS }}
+      # - name: Use Emmett shims in the browser compatibility test project
+      #   working-directory: ./src/e2e/browser
+      #   run: npm install ../esmCompatibility/${{ env.PACKAGE_FILENAME_SHIMS }}
 
       - name: Use Emmett in the browser compatibility test project
         working-directory: ./src/e2e/browser

diff --git a/src/e2e/browser/index.html b/src/e2e/browser/index.html
@@ -16,10 +16,6 @@
     </script>
   </head>
   <body>
-    <!-- Load the bundled file -->
-    <!-- <script src="./node_modules/@event-driven-io/emmett/dist/index.js"></script> -->
-
-    <!-- Test script -->
     <script type="module">
       import { getInMemoryEventStore } from '@event-driven-io/emmett';
 

diff --git a/src/package-lock.json b/src/package-lock.json
diff --git a/src/package.json b/src/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@event-driven-io/core",
   "type": "module",
-  "version": "0.20.1",
+  "version": "0.20.2-alpha.4",
   "description": "Emmett - Event Sourcing development made simple",
   "engines": {
     "node": ">=20.11.1"

diff --git a/src/packages/emmett-esdb/package.json b/src/packages/emmett-esdb/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@event-driven-io/emmett-esdb",
   "type": "module",
-  "version": "0.20.1",
+  "version": "0.20.2-alpha.4",
   "description": "Emmett - EventStoreDB - Event Sourcing development made simple",
   "scripts": {
     "build": "tsup",
@@ -48,10 +48,10 @@
   ],
   "dependencies": {},
   "devDependencies": {
-    "@event-driven-io/emmett-testcontainers": "0.20.1"
+    "@event-driven-io/emmett-testcontainers": "0.20.2-alpha.4"
   },
   "peerDependencies": {
-    "@event-driven-io/emmett": "0.20.1",
+    "@event-driven-io/emmett": "0.20.2-alpha.4",
     "@eventstore/db-client": "^6.2.1"
   }
 }
diff --git a/src/packages/emmett-esdb/tsup.config.ts b/src/packages/emmett-esdb/tsup.config.ts
@@ -2,18 +2,36 @@ import { defineConfig } from 'tsup';
 
 const env = process.env.NODE_ENV;
 
-export default defineConfig({
-  splitting: true,
-  clean: true, // clean up the dist folder
-  dts: true, // generate dts files
-  format: ['cjs', 'esm'], // generate cjs and esm files
-  minify: true, //env === 'production',
-  bundle: true, //env === 'production',
-  skipNodeModulesBundle: true,
-  watch: env === 'development',
-  target: 'esnext',
-  outDir: 'dist', //env === 'production' ? 'dist' : 'lib',
-  entry: ['src/index.ts'],
-  sourcemap: true,
-  tsconfig: 'tsconfig.build.json', // workaround for https://github.com/egoist/tsup/issues/571#issuecomment-1760052931
-});
+export default defineConfig([
+  {
+    format: ['cjs'],
+    splitting: true,
+    clean: true,
+    dts: true,
+    // TODO: For some reason minified code doesn't work for cjs
+    minify: false, //env === 'production',
+    bundle: true, //env === 'production',
+    skipNodeModulesBundle: true,
+    watch: env === 'development',
+    target: 'esnext',
+    outDir: 'dist', //env === 'production' ? 'dist' : 'lib',
+    entry: ['src/index.ts'],
+    sourcemap: true,
+    tsconfig: 'tsconfig.build.json', // workaround for https://github.com/egoist/tsup/issues/571#issuecomment-1760052931
+  },
+  {
+    format: ['esm'],
+    splitting: true,
+    clean: true,
+    dts: true,
+    minify: true, //env === 'production',
+    bundle: true, //env === 'production',
+    skipNodeModulesBundle: true,
+    watch: env === 'development',
+    target: 'esnext',
+    outDir: 'dist', //env === 'production' ? 'dist' : 'lib',
+    entry: ['src/index.ts'],
+    sourcemap: true,
+    tsconfig: 'tsconfig.build.json', // workaround for https://github.com/egoist/tsup/issues/571#issuecomment-1760052931
+  },
+]);
diff --git a/src/packages/emmett-expressjs/package.json b/src/packages/emmett-expressjs/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@event-driven-io/emmett-expressjs",
-  "version": "0.20.1",
+  "version": "0.20.2-alpha.4",
   "type": "module",
   "description": "Emmett - Event Sourcing development made simple",
   "scripts": {
@@ -49,7 +49,7 @@
   "dependencies": {},
   "devDependencies": {},
   "peerDependencies": {
-    "@event-driven-io/emmett": "0.20.1",
+    "@event-driven-io/emmett": "0.20.2-alpha.4",
     "@types/express": "^4.17.21",
     "@types/supertest": "^6.0.2",
     "express": "^4.19.2",

diff --git a/src/packages/emmett-expressjs/tsup.config.ts b/src/packages/emmett-expressjs/tsup.config.ts
@@ -2,18 +2,36 @@ import { defineConfig } from 'tsup';
 
 const env = process.env.NODE_ENV;
 
-export default defineConfig({
-  splitting: true,
-  clean: true, // clean up the dist folder
-  dts: true, // generate dts files
-  format: ['cjs', 'esm'], // generate cjs and esm files
-  minify: true, //env === 'production',
-  bundle: true, //env === 'production',
-  skipNodeModulesBundle: true,
-  watch: env === 'development',
-  target: 'esnext',
-  outDir: 'dist', //env === 'production' ? 'dist' : 'lib',
-  entry: ['src/index.ts'],
-  sourcemap: true,
-  tsconfig: 'tsconfig.build.json', // workaround for https://github.com/egoist/tsup/issues/571#issuecomment-1760052931
-});
+export default defineConfig([
+  {
+    format: ['cjs'],
+    splitting: true,
+    clean: true,
+    dts: true,
+    // TODO: For some reason minified code doesn't work for cjs
+    minify: false, //env === 'production',
+    bundle: true, //env === 'production',
+    skipNodeModulesBundle: true,
+    watch: env === 'development',
+    target: 'esnext',
+    outDir: 'dist', //env === 'production' ? 'dist' : 'lib',
+    entry: ['src/index.ts'],
+    sourcemap: true,
+    tsconfig: 'tsconfig.build.json', // workaround for https://github.com/egoist/tsup/issues/571#issuecomment-1760052931
+  },
+  {
+    format: ['esm'],
+    splitting: true,
+    clean: true,
+    dts: true,
+    minify: true, //env === 'production',
+    bundle: true, //env === 'production',
+    skipNodeModulesBundle: true,
+    watch: env === 'development',
+    target: 'esnext',
+    outDir: 'dist', //env === 'production' ? 'dist' : 'lib',
+    entry: ['src/index.ts'],
+    sourcemap: true,
+    tsconfig: 'tsconfig.build.json', // workaround for https://github.com/egoist/tsup/issues/571#issuecomment-1760052931
+  },
+]);
diff --git a/src/packages/emmett-fastify/package.json b/src/packages/emmett-fastify/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@event-driven-io/emmett-fastify",
-  "version": "0.20.1",
+  "version": "0.20.2-alpha.4",
   "type": "module",
   "description": "Emmett - Event Sourcing development made simple",
   "scripts": {
@@ -53,7 +53,7 @@
   "dependencies": {},
   "devDependencies": {},
   "peerDependencies": {
-    "@event-driven-io/emmett": "0.20.1",
+    "@event-driven-io/emmett": "0.20.2-alpha.4",
     "fastify": "^4.28.1",
     "@fastify/compress": "^7.0.3",
     "@fastify/etag": "^5.2.0",

diff --git a/src/packages/emmett-fastify/tsup.config.ts b/src/packages/emmett-fastify/tsup.config.ts
@@ -2,18 +2,36 @@ import { defineConfig } from 'tsup';
 
 const env = process.env.NODE_ENV;
 
-export default defineConfig({
-  splitting: true,
-  clean: true, // clean up the dist folder
-  dts: true, // generate dts files
-  format: ['cjs', 'esm'], // generate cjs and esm files
-  minify: true, //env === 'production',
-  bundle: true, //env === 'production',
-  skipNodeModulesBundle: true,
-  watch: env === 'development',
-  target: 'esnext',
-  outDir: 'dist', //env === 'production' ? 'dist' : 'lib',
-  entry: ['src/index.ts'],
-  sourcemap: true,
-  tsconfig: 'tsconfig.build.json', // workaround for https://github.com/egoist/tsup/issues/571#issuecomment-1760052931
-});
+export default defineConfig([
+  {
+    format: ['cjs'],
+    splitting: true,
+    clean: true,
+    dts: true,
+    // TODO: For some reason minified code doesn't work for cjs
+    minify: false, //env === 'production',
+    bundle: true, //env === 'production',
+    skipNodeModulesBundle: true,
+    watch: env === 'development',
+    target: 'esnext',
+    outDir: 'dist', //env === 'production' ? 'dist' : 'lib',
+    entry: ['src/index.ts'],
+    sourcemap: true,
+    tsconfig: 'tsconfig.build.json', // workaround for https://github.com/egoist/tsup/issues/571#issuecomment-1760052931
+  },
+  {
+    format: ['esm'],
+    splitting: true,
+    clean: true,
+    dts: true,
+    minify: true, //env === 'production',
+    bundle: true, //env === 'production',
+    skipNodeModulesBundle: true,
+    watch: env === 'development',
+    target: 'esnext',
+    outDir: 'dist', //env === 'production' ? 'dist' : 'lib',
+    entry: ['src/index.ts'],
+    sourcemap: true,
+    tsconfig: 'tsconfig.build.json', // workaround for https://github.com/egoist/tsup/issues/571#issuecomment-1760052931
+  },
+]);
diff --git a/src/packages/emmett-postgresql/package.json b/src/packages/emmett-postgresql/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@event-driven-io/emmett-postgresql",
-  "version": "0.20.1",
+  "version": "0.20.2-alpha.4",
   "type": "module",
   "description": "Emmett - PostgreSQL - Event Sourcing development made simple",
   "scripts": {
@@ -70,10 +70,10 @@
   ],
   "devDependencies": {
     "@testcontainers/postgresql": "^10.12.0",
-    "@event-driven-io/emmett-testcontainers": "0.20.1"
+    "@event-driven-io/emmett-testcontainers": "0.20.2-alpha.4"
   },
   "peerDependencies": {
-    "@event-driven-io/emmett": "0.20.1",
+    "@event-driven-io/emmett": "0.20.2-alpha.4",
     "@event-driven-io/pongo": "0.16.1"
   }
 }